Backups/TwelveMonkeys
2
0
Fork 0
mirror of https://github.com/haraldk/TwelveMonkeys.git synced 2026-03-20 00:00:03 -04:00
Code Issues Projects Releases Wiki Activity

Fixed a bug in the MappedFileBuffer + added test case for exposing the bug.

Browse Source
This commit is contained in:
Harald Kuhr
2012-06-01 14:42:48 +02:00
parent 7f2ad765cf
commit 37e9adcfec
2 changed files with 141 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
sandbox/sandbox-common/src/main/java/com/twelvemonkeys/image/MappedFileBuffer.java
View File

@@ -52,7 +52,7 @@ public abstract class MappedFileBuffer extends DataBuffer {
private final Buffer buffer;
private MappedFileBuffer(final int type, final int size, final int numBanks) throws IOException {
super(type, Validate.isTrue(size >= 0, size, "Integer overflow for size: %d"), numBanks);
super(type, Validate.isTrue(size >= 0, size, "Integer overflow for size: %d"), Validate.isTrue(numBanks >= 0, numBanks, "Number of banks must be positive"));
int componentSize = DataBuffer.getDataTypeSize(type) / 8;
@@ -125,7 +125,7 @@ public abstract class MappedFileBuffer extends DataBuffer {
@Override
public int getElem(int bank, int i) {
return buffer.get(bank * size + i);
return buffer.get(bank * size + i) & 0xff;
}
@Override
@@ -144,12 +144,12 @@ public abstract class MappedFileBuffer extends DataBuffer {
@Override
public int getElem(int bank, int i) {
return buffer.get(bank * size + i);
return buffer.get(bank * size + i) & 0xffff;
}
@Override
public void setElem(int bank, int i, int val) {
buffer.put(bank * size + i, (short) (val & 0xffff));
buffer.put(bank * size + i, (short) val);
}
}