Backups/TwelveMonkeys
2
0
Fork 0
mirror of https://github.com/haraldk/TwelveMonkeys.git synced 2026-04-04 00:00:01 -04:00
Code Issues Projects Releases Wiki Activity

TMC-IOENC-11: Fixed problem introduced when migrating byte[] -> ByteBuffer

Browse Source
This commit is contained in:
Harald Kuhr
2013-09-27 14:21:31 +02:00
parent cd197afc04
commit 1acc04eeaf
5 changed files with 33 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
common/common-io/src/test/java/com/twelvemonkeys/io/enc/EncoderAbstractTestCase.java
View File

@@ -54,7 +54,12 @@ public abstract class EncoderAbstractTestCase extends ObjectAbstractTestCase {
OutputStream out = new EncoderStream(outBytes, createEncoder(), true);
try {
out.write(data);
// Provoke failure for encoders that doesn't take array offset properly into account
int off = (data.length + 1) / 2;
out.write(data, 0, off);
if (data.length > off) {
out.write(data, off, data.length - off);
}
}
finally {
out.close();
@@ -127,4 +132,8 @@ public abstract class EncoderAbstractTestCase extends ObjectAbstractTestCase {
}
}
}
// TODO: Test that the transition from byte[] to ByteBuffer didn't introduce bugs when writing to a wrapped array with offset.
}

5
common/common-io/src/test/java/com/twelvemonkeys/io/enc/PackBitsEncoderTestCase.java
View File

@@ -1,10 +1,5 @@
package com.twelvemonkeys.io.enc;
import com.twelvemonkeys.io.enc.Decoder;
import com.twelvemonkeys.io.enc.Encoder;
import com.twelvemonkeys.io.enc.PackBitsDecoder;
import com.twelvemonkeys.io.enc.PackBitsEncoder;
/**
* PackBitsEncoderTest
* <p/>