Merge pull request #175 from douglascrockford/release-20151123

Update readme for 20151123 release

JSONArray.java

@@ -76,7 +76,7 @@ import java.util.Map;
  * </ul>
  *
  * @author JSON.org
- * @version 2015-07-22
+ * @version 2015-10-29
  */
 public class JSONArray implements Iterable<Object> {
 
@@ -151,13 +151,12 @@ public class JSONArray implements Iterable<Object> {
      * @param collection
      *            A Collection.
      */
-    public JSONArray(Collection<Object> collection) {
+    public JSONArray(Collection<?> collection) {
         this.myArrayList = new ArrayList<Object>();
         if (collection != null) {
-            Iterator<Object> iter = collection.iterator();
+        	for (Object o: collection){
-            while (iter.hasNext()) {
+        		this.myArrayList.add(JSONObject.wrap(o));
-                this.myArrayList.add(JSONObject.wrap(iter.next()));
+        	}
-            }
         }
     }
 
@@ -746,7 +745,7 @@ public class JSONArray implements Iterable<Object> {
      *            A Collection value.
      * @return this.
      */
-    public JSONArray put(Collection<Object> value) {
+    public JSONArray put(Collection<?> value) {
         this.put(new JSONArray(value));
         return this;
     }
@@ -799,7 +798,7 @@ public class JSONArray implements Iterable<Object> {
      *            A Map value.
      * @return this.
      */
-    public JSONArray put(Map<String, Object> value) {
+    public JSONArray put(Map<?, ?> value) {
         this.put(new JSONObject(value));
         return this;
     }
@@ -848,7 +847,7 @@ public class JSONArray implements Iterable<Object> {
      * @throws JSONException
      *             If the index is negative or if the value is not finite.
      */
-    public JSONArray put(int index, Collection<Object> value) throws JSONException {
+    public JSONArray put(int index, Collection<?> value) throws JSONException {
         this.put(index, new JSONArray(value));
         return this;
     }
@@ -920,7 +919,7 @@ public class JSONArray implements Iterable<Object> {
      *             If the index is negative or if the the value is an invalid
      *             number.
      */
-    public JSONArray put(int index, Map<String, Object> value) throws JSONException {
+    public JSONArray put(int index, Map<?, ?> value) throws JSONException {
         this.put(index, new JSONObject(value));
         return this;
     }

JSONException.java

@@ -4,11 +4,11 @@ package org.json;
  * The JSONException is thrown by the JSON.org classes when things are amiss.
  *
  * @author JSON.org
- * @version 2014-05-03
+ * @version 2015-10-18
  */
 public class JSONException extends RuntimeException {
+    /** Serialization ID */
     private static final long serialVersionUID = 0;
-    private Throwable cause;
 
     /**
      * Constructs a JSONException with an explanatory message.
@@ -16,28 +16,30 @@ public class JSONException extends RuntimeException {
      * @param message
      *            Detail about the reason for the exception.
      */
-    public JSONException(String message) {
+    public JSONException(final String message) {
         super(message);
     }
 
     /**
-     * Constructs a new JSONException with the specified cause.
+     * Constructs a JSONException with an explanatory message and cause.
-     * @param cause The cause.
+     * 
+     * @param message
+     *            Detail about the reason for the exception.
+     * @param cause
+     *            The cause.
      */
-    public JSONException(Throwable cause) {
+    public JSONException(final String message, final Throwable cause) {
-        super(cause.getMessage());
+        super(message, cause);
-        this.cause = cause;
     }
 
     /**
-     * Returns the cause of this exception or null if the cause is nonexistent
+     * Constructs a new JSONException with the specified cause.
-     * or unknown.
+     * 
-     *
+     * @param cause
-     * @return the cause of this exception or null if the cause is nonexistent
+     *            The cause.
-     *          or unknown.
      */
-    @Override
+    public JSONException(final Throwable cause) {
-    public Throwable getCause() {
+        super(cause.getMessage(), cause);
-        return this.cause;
     }
+
 }

JSONObject.java

@@ -92,7 +92,7 @@ import java.util.Set;
  * </ul>
  *
  * @author JSON.org
- * @version 2015-07-22
+ * @version 2015-10-29
  */
 public class JSONObject {
     /**
@@ -243,15 +243,13 @@ public class JSONObject {
      *            the JSONObject.
      * @throws JSONException
      */
-    public JSONObject(Map<String, Object> map) {
+    public JSONObject(Map<?, ?> map) {
         this.map = new HashMap<String, Object>();
         if (map != null) {
-            Iterator<Entry<String, Object>> i = map.entrySet().iterator();
+        	for (final Entry<?, ?> e : map.entrySet()) {
-            while (i.hasNext()) {
+                final Object value = e.getValue();
-                Entry<String, Object> entry = i.next();
-                Object value = entry.getValue();
                 if (value != null) {
-                    this.map.put(entry.getKey(), wrap(value));
+                    this.map.put(String.valueOf(e.getKey()), wrap(value));
                 }
             }
         }
@@ -1204,7 +1202,7 @@ public class JSONObject {
      * @return this.
      * @throws JSONException
      */
-    public JSONObject put(String key, Collection<Object> value) throws JSONException {
+    public JSONObject put(String key, Collection<?> value) throws JSONException {
         this.put(key, new JSONArray(value));
         return this;
     }
@@ -1268,7 +1266,7 @@ public class JSONObject {
      * @return this.
      * @throws JSONException
      */
-    public JSONObject put(String key, Map<String, Object> value) throws JSONException {
+    public JSONObject put(String key, Map<?, ?> value) throws JSONException {
         this.put(key, new JSONObject(value));
         return this;
     }
@@ -1663,13 +1661,11 @@ public class JSONObject {
             return value.toString();
         }
         if (value instanceof Map) {
-            @SuppressWarnings("unchecked")
+            Map<?, ?> map = (Map<?, ?>) value;
-            Map<String, Object> map = (Map<String, Object>) value;
             return new JSONObject(map).toString();
         }
         if (value instanceof Collection) {
-            @SuppressWarnings("unchecked")
+            Collection<?> coll = (Collection<?>) value;
-            Collection<Object> coll = (Collection<Object>) value;
             return new JSONArray(coll).toString();
         }
         if (value.getClass().isArray()) {
@@ -1707,16 +1703,14 @@ public class JSONObject {
             }
 
             if (object instanceof Collection) {
-                @SuppressWarnings("unchecked")
+                Collection<?> coll = (Collection<?>) object;
-                Collection<Object> coll = (Collection<Object>) object;
                 return new JSONArray(coll);
             }
             if (object.getClass().isArray()) {
                 return new JSONArray(object);
             }
             if (object instanceof Map) {
-                @SuppressWarnings("unchecked")
+                Map<?, ?> map = (Map<?, ?>) object;
-                Map<String, Object> map = (Map<String, Object>) object;
                 return new JSONObject(map);
             }
             Package objectPackage = object.getClass().getPackage();
@@ -1755,14 +1749,11 @@ public class JSONObject {
         } else if (value instanceof JSONArray) {
             ((JSONArray) value).write(writer, indentFactor, indent);
         } else if (value instanceof Map) {
-            @SuppressWarnings("unchecked")
+            Map<?, ?> map = (Map<?, ?>) value;
-            Map<String, Object> map = (Map<String, Object>) value;
             new JSONObject(map).write(writer, indentFactor, indent);
         } else if (value instanceof Collection) {
-            @SuppressWarnings("unchecked")
+            Collection<?> coll = (Collection<?>) value;
-            Collection<Object> coll = (Collection<Object>) value;
+            new JSONArray(coll).write(writer, indentFactor, indent);
-            new JSONArray(coll).write(writer, indentFactor,
-                    indent);
         } else if (value.getClass().isArray()) {
             new JSONArray(value).write(writer, indentFactor, indent);
         } else if (value instanceof Number) {

README

@@ -62,3 +62,13 @@ JSONML.java: JSONML provides support for converting between JSONML and XML.
 XMLTokener.java: XMLTokener extends JSONTokener for parsing XML text.
 
 Unit tests are maintained in a separate project. Contributing developers can test JSON-java pull requests with the code in this project: https://github.com/stleary/JSON-Java-unit-test
+
+Release history:
+
+20151123    JSONObject and JSONArray initialization with generics. Contains the
+latest code as of 23 Nov, 2015.
+
+20150729    Checkpoint for Maven central repository release. Contains the latest code as of 29 July, 2015. 
+
+JSON-java releases can be found by searching the Maven repository for groupId "org.json" and artifactId "json". For example: 
+https://search.maven.org/#search%7Cgav%7C1%7Cg%3A%22org.json%22%20AND%20a%3A%22json%22

XML.java

@@ -1,7 +1,7 @@
 package org.json;
 
 /*
-Copyright (c) 2002 JSON.org
+Copyright (c) 2015 JSON.org
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
@@ -30,7 +30,7 @@ import java.util.Iterator;
  * This provides static methods to convert an XML text into a JSONObject,
  * and to covert a JSONObject into an XML text.
  * @author JSON.org
- * @version 2014-05-03
+ * @version 2015-10-18
  */
 public class XML {
 
@@ -468,10 +468,12 @@ public class XML {
 // XML does not have good support for arrays. If an array appears in a place
 // where XML is lacking, synthesize an <array> element.
 
-        } else {
+        }
+        if(object!=null){
             if (object.getClass().isArray()) {
                 object = new JSONArray(object);
             }
+            
             if (object instanceof JSONArray) {
                 ja = (JSONArray)object;
                 length = ja.length();
@@ -479,12 +481,12 @@ public class XML {
                     sb.append(toString(ja.opt(i), tagName == null ? "array" : tagName));
                 }
                 return sb.toString();
-            } else {
-                string = (object == null) ? "null" : escape(object.toString());
-                return (tagName == null) ? "\"" + string + "\"" :
-                    (string.length() == 0) ? "<" + tagName + "/>" :
-                    "<" + tagName + ">" + string + "</" + tagName + ">";
             }
         }
+        string = (object == null) ? "null" : escape(object.toString());
+        return (tagName == null) ? "\"" + string + "\"" :
+            (string.length() == 0) ? "<" + tagName + "/>" :
+            "<" + tagName + ">" + string + "</" + tagName + ">";
+            
     }
 }